Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactoring to fit cloud build service account changes #52

Merged
merged 2 commits into from
Jun 20, 2024
Merged

fix: refactoring to fit cloud build service account changes #52

merged 2 commits into from
Jun 20, 2024

Conversation

caetano-colin
Copy link
Contributor

  • Use custom service accounts for build triggers, this implies in creating a storage bucket and manually assigning permissions.
  • Fix README.md step
  • Create missing symbolic link 5-app-infra/projects/service-catalog/business_unit_3/shared/common.auto.tfvars
  • Fix variables file 5-app-infra/projects/service-catalog/common.auto.example.tfvars

Reference: https://cloud.google.com/build/docs/cloud-build-service-account-updates

@caetano-colin caetano-colin marked this pull request as ready for review June 20, 2024 12:06
@sleighton2022 sleighton2022 merged commit a7eacab into GoogleCloudPlatform:main Jun 20, 2024
2 checks passed
@release-please release-please bot mentioned this pull request Jun 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caetano-colin @sleighton2022